Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for linux and windows web app #13

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: Added support for linux and windows web app #13

wants to merge 8 commits into from

Conversation

NotMaharshi
Copy link
Member

what

  • Checked and removed deprecated resources
  • Updated module with latest terraform version

why

  • There were a lot of changes like app service resource is now divided into two resources linux_web_app and windows_web_app
  • Removed Application insights portal error

@NotMaharshi NotMaharshi requested review from 13archit and d4kverma July 15, 2024 09:13
@NotMaharshi NotMaharshi self-assigned this Jul 15, 2024
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
13archit
13archit reviewed Aug 5, 2024
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13archit 13archit 13archit left review comments

@d4kverma d4kverma Awaiting requested review from d4kverma

Assignees

@NotMaharshi NotMaharshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotMaharshi @13archit